Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release .zip instead of .tar.gz for windows in sdkman #20630

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Jun 19, 2024

@hamzaremmal
Copy link
Member Author

I've just discussed with @marc0der about the presence of UNIVERSAL and we should remove it from the workflow

@hamzaremmal hamzaremmal marked this pull request as ready for review June 21, 2024 10:12
@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jun 21, 2024
Copy link

@marc0der marc0der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hamzaremmal
Copy link
Member Author

Thanks @marc0der for taking the time to check the workflow !

@hamzaremmal hamzaremmal merged commit 5db826a into scala:main Jun 21, 2024
22 checks passed
@hamzaremmal hamzaremmal deleted the sdkman-windows-zip branch June 21, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants