-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SIP 57 - add runtimeChecked method and annotation #20987
Conversation
677560c
to
5cb3301
Compare
For the future: once the definition is stabilised, we can deprecate And also later possibly a language mode could introduce that refutable pattern bindings become an error? |
5cb3301
to
9a866c2
Compare
9a866c2
to
853920d
Compare
853920d
to
e8f9812
Compare
e8f9812
to
d29ec53
Compare
@Gedochao how can I get this reviewed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some suggestions for the doc page. Otherwise LGTM.
improve documentation based on suggestions Co-authored-by: odersky <odersky@gmail.com>
fc54f16
to
5595bdd
Compare
ref: https://docs.scala-lang.org/sips/replace-nonsensical-unchecked-annotation.html
Also this doesn't change synthetic code that is generated to use
@unchecked
, or make@unchecked
meaningless for this use case - this should probably come at a later stage after the definition is no longer experimentalfixes #21012