Skip to content

Always rewrite empty List() to Nil #21689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

Always rewrite empty List() to Nil #21689

merged 1 commit into from
Oct 2, 2024

Conversation

som-snytt
Copy link
Contributor

List[String]() was OK but not List() with Nothing inferred, which is how people write it.

Follow-up to #17166

Noticed at scala/scala#10876

@sjrd sjrd merged commit c332766 into scala:main Oct 2, 2024
28 checks passed
@som-snytt som-snytt deleted the issue/missing-nil branch October 2, 2024 13:57
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
@WojciechMazur WojciechMazur mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@som-snytt @sjrd @WojciechMazur