Skip to content

Render line and col in error message for clickability #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2017
Merged

Render line and col in error message for clickability #2268

merged 1 commit into from
Apr 16, 2017

Conversation

felixmulder
Copy link
Contributor

No description provided.

@felixmulder felixmulder requested a review from olafurpg April 16, 2017 08:54
olafurpg
olafurpg approved these changes Apr 16, 2017
View reviewed changes
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice to get the column number too.

@felixmulder felixmulder merged commit ab124cb into scala:master Apr 16, 2017
@felixmulder felixmulder deleted the topic/add-line-col branch April 16, 2017 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@olafurpg olafurpg olafurpg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixmulder @olafurpg