Skip to content

Conversation

smarter
Copy link
Member

@smarter smarter commented Apr 23, 2017

Now that #2260 has been merged, nothing is holding us back from upgrading.

smarter added 2 commits April 23, 2017 18:42
Now that scala#2260 has been merged, nothing is holding us back from upgrading.
As explained in the deprecated message:
"method toImmutable in class BitSet is deprecated: If this BitSet
contains a value that is 128 or greater, the result of this method is an
'immutable' BitSet that shares state with this mutable BitSet. Thus, if
the mutable BitSet is modified, it will violate the immutability of the
result"
@smarter smarter requested a review from felixmulder April 23, 2017 16:45
Copy link
Contributor

@felixmulder felixmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to rebuild the cache.

@smarter smarter merged commit 2d06ea6 into scala:master Apr 23, 2017
@smarter
Copy link
Member Author

smarter commented Apr 23, 2017

Yes: #2290 (comment)

@allanrenucci allanrenucci deleted the upgrade/scala2.11.11 branch December 14, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants