Bot improvements - CLA checks, killing old jobs, nagging about form #2304

felixmulder · 2017-04-25T09:10:15Z

Bot improvements include:

Deleting old jobs from PR, only keep the latest drone build
Check CLA and only approve last commit
Add some greetings to opened PRs helping people on where to sign CLA etc

felixmulder · 2017-04-25T11:34:20Z

@dotty-bot: could you recheck this please?

DarkDimius · 2017-04-25T11:36:18Z

Add some greetings to opened PRs helping people on where to sign CLA etc

would it be only for new commiters?

dottybot · 2017-04-25T12:59:04Z

Sure thing, I got your back! ❤️

felixmulder · 2017-04-25T13:11:51Z

@dotty-bot: hey, need you to recheck this again please.

dottybot · 2017-04-25T13:11:59Z

Sure thing, I got your back! ❤️

felixmulder · 2017-04-25T13:13:54Z

@dotty-bot: do you always say the same thing? Please recheck.

dottybot · 2017-04-25T13:14:01Z

You got it, homie! 🙏

felixmulder · 2017-04-25T13:24:51Z

@dotty-bot: I don't like you.

dottybot · 2017-04-25T13:24:56Z

Hey, sorry - I could not understand what you meant by:

@dotty-bot: i don't like you.

I'm just a dumb bot after all 😢

I mostly understand when your mention contains these words:

check (the) cla
recheck
restart drone

Maybe if you want to make me smarter, you could open a PR? 😍

OlivierBlanvillain

LGTM 👍

OlivierBlanvillain · 2017-04-27T06:47:41Z

bot/src/dotty/tools/bot/PullRequestService.scala

-
-  def shutdownClient(client: Client): Unit =
-    client.shutdownNow()
+  def shutdownClient(client: Client): Task[Unit] =


Any reason for this over client.shutdown?

OlivierBlanvillain · 2017-04-27T06:52:30Z

bot/src/dotty/tools/bot/PullRequestService.scala

+      val firstWord = firstLine.takeWhile(x => x != ':' && x != ' ')
+      val containsColon = firstLine.contains(':')
+
+      val wrongTense = firstWord match {


OlivierBlanvillain · 2017-04-27T06:57:20Z

bot/src/dotty/tools/bot/PullRequestService.scala

+        => false
+      }
+
+      wrongTense || firstLine.last == '.' || firstLine.length > 100


This should be 72. Github starts wrapping first lines after that: https://github.com/OlivierBlanvillain/dotty/commits/git-test

(If change, don't forget to also update the message)

OlivierBlanvillain · 2017-04-27T07:03:00Z

bot/src/dotty/tools/bot/PullRequestService.scala

+          cancellable =  statuses.filter(status => status.state == "pending" && status.context == droneContext)
+          runningJobs =  cancellable.map(_.target_url.split('/').last.toInt)
+          cancelled   <- Task.gatherUnordered(runningJobs.map(Drone.stopBuild(_, droneToken)))
+        } yield cancelled.foldLeft(true)(_ == _)


.forall(identity) :)

OlivierBlanvillain · 2017-04-27T07:06:09Z

bot/src/dotty/tools/bot/PullRequestService.scala

+  def extractMention(body: String): Option[String] =
+    body.lines.find(_.startsWith("@dotty-bot:"))
+
+  /** TODO: The implementation here could be quite elegant if we used a trie instead */


I think you can turn this into a Note:...

felixmulder · 2017-04-27T09:46:45Z

Made the suggested changes (mostly). As this doesn't do anything inside the compiler, I cancelled the CI jobs.

felixmulder · 2017-04-27T09:46:54Z

thanks @OlivierBlanvillain !

OlivierBlanvillain · 2017-04-27T09:55:24Z

bot/src/dotty/tools/bot/PullRequestService.scala

@@ -207,7 +204,7 @@ trait PullRequestService {
        => false
      }

-      wrongTense || firstLine.last == '.' || firstLine.length > 100
+      wrongTense || firstLine.last == '.' || firstLine.length > 80


felixmulder · 2017-04-27T12:31:52Z

I'm telling people that it's 72 (see bot message), but come on - let's allow a bit of slack ;)

…

On Thu, Apr 27, 2017, 11:55 Olivier Blanvillain ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In bot/src/dotty/tools/bot/PullRequestService.scala <#2304 (comment)>: > @@ -207,7 +204,7 @@ trait PullRequestService { => false } - wrongTense || firstLine.last == '.' || firstLine.length > 100 + wrongTense || firstLine.last == '.' || firstLine.length > 80 72 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2304 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABdYwTjWOs3h2r9asj1iajUBjFSiFYpvks5r0GYNgaJpZM4NHMz2> .

dottybot · 2017-08-24T09:55:23Z

Hey, sorry - I could not understand what you meant by:

@dotty-bot: I don't like you.

I'm just a dumb bot after all 😢

I mostly understand when your mention contains these words:

(re)check (the) cla
recheck
restart drone

Maybe if you want to make me smarter, you could open a PR? 😍

dottybot · 2017-08-24T09:55:45Z

Okidokey, boss! 👏

smarter · 2017-08-24T09:58:07Z

It lives!

dottybot · 2017-12-07T15:48:06Z

Hey, sorry - I could not understand what you meant by:

@dotty-bot: I don't like you.

I'm just a dumb bot after all 😢

I mostly understand when your mention contains these words:

(re)check (the) cla
recheck
restart drone

Maybe if you want to make me smarter, you could open a PR? 😍

dottybot · 2017-12-07T15:50:06Z

Hey, sorry - I could not understand what you meant by:

@dotty-bot: I don't like you.

I'm just a dumb bot after all 😢

I mostly understand when your mention contains these words:

(re)check (the) cla
recheck
restart drone

Maybe if you want to make me smarter, you could open a PR? 😍

dottybot · 2017-12-08T10:35:07Z

Hey, sorry - I could not understand what you meant by:

@dotty-bot: I don't like you.

I'm just a dumb bot after all 😢

I mostly understand when your mention contains these words:

(re)check (the) cla
recheck
restart drone

Maybe if you want to make me smarter, you could open a PR? 😍

dottybot · 2017-12-08T14:08:33Z

Hey, sorry - I could not understand what you meant by:

@dotty-bot: I don't like you.

I'm just a dumb bot after all 😢

I mostly understand when your mention contains these words:

(re)check (the) cla
recheck
restart drone

Maybe if you want to make me smarter, you could open a PR? 😍

dottybot · 2017-12-09T20:49:25Z

Hey, sorry - I could not understand what you meant by:

@dotty-bot: I don't like you.

I'm just a dumb bot after all 😢

I mostly understand when your mention contains these words:

(re)check (the) cla
recheck
restart drone

Maybe if you want to make me smarter, you could open a PR? 😍

felixmulder requested a review from OlivierBlanvillain April 25, 2017 09:10

felixmulder force-pushed the topic/improve-bot branch 2 times, most recently from 5b06ac6 to aa30c2b Compare April 25, 2017 09:17

felixmulder added 7 commits April 25, 2017 14:56

Add bot ability to get issue comments

b49faeb

Change to approving only latest commit, stub methods

e6ca06a

Implement rechecking of CLA

6a633ef

Use withClient helper in all tests

4263907

Implement posting initial comment

8494fc5

Factor out HTTP client functionality

01da59f

Add ability for bot to stop outdated jobs

51f8bc1

felixmulder force-pushed the topic/improve-bot branch from aa30c2b to 51f8bc1 Compare April 25, 2017 12:56

Add ability for bot to restart things when mentioned

aad721f

OlivierBlanvillain approved these changes Apr 27, 2017

View reviewed changes

Get rid of unnecessary foldLefts and shutdownClient

595602d

felixmulder merged commit 0de9004 into scala:master Apr 27, 2017

OlivierBlanvillain reviewed Apr 27, 2017

View reviewed changes

allanrenucci deleted the topic/improve-bot branch December 14, 2017 19:25

Bot improvements - CLA checks, killing old jobs, nagging about form #2304

Bot improvements - CLA checks, killing old jobs, nagging about form #2304

Uh oh!

Conversation

felixmulder commented Apr 25, 2017

Uh oh!

felixmulder commented Apr 25, 2017

Uh oh!

DarkDimius commented Apr 25, 2017

Uh oh!

dottybot commented Apr 25, 2017

Uh oh!

felixmulder commented Apr 25, 2017

Uh oh!

dottybot commented Apr 25, 2017

Uh oh!

felixmulder commented Apr 25, 2017

Uh oh!

dottybot commented Apr 25, 2017

Uh oh!

felixmulder commented Apr 25, 2017

Uh oh!

dottybot commented Apr 25, 2017 • edited by felixmulder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OlivierBlanvillain left a comment

Choose a reason for hiding this comment

Uh oh!

OlivierBlanvillain Apr 27, 2017

Choose a reason for hiding this comment

Uh oh!

OlivierBlanvillain Apr 27, 2017

Choose a reason for hiding this comment

Uh oh!

OlivierBlanvillain Apr 27, 2017

Choose a reason for hiding this comment

Uh oh!

OlivierBlanvillain Apr 27, 2017

Choose a reason for hiding this comment

Uh oh!

OlivierBlanvillain Apr 27, 2017

Choose a reason for hiding this comment

Uh oh!

felixmulder commented Apr 27, 2017

Uh oh!

felixmulder commented Apr 27, 2017

Uh oh!

OlivierBlanvillain Apr 27, 2017

Choose a reason for hiding this comment

Uh oh!

felixmulder commented Apr 27, 2017 via email

Uh oh!

dottybot commented Aug 24, 2017

Uh oh!

dottybot commented Aug 24, 2017

Uh oh!

smarter commented Aug 24, 2017

Uh oh!

dottybot commented Dec 7, 2017

Uh oh!

dottybot commented Dec 7, 2017

Uh oh!

dottybot commented Dec 8, 2017

Uh oh!

dottybot commented Dec 8, 2017

Uh oh!

dottybot commented Dec 9, 2017

Uh oh!

Uh oh!

dottybot commented Apr 25, 2017 •

edited by felixmulder

Loading