Skip to content

fix: synthesise value of this.type in ValueOf #23094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2025
Merged

fix: synthesise value of this.type in ValueOf #23094

merged 1 commit into from
May 3, 2025

Conversation

hamzaremmal
Copy link
Member

Closes #23086

@hamzaremmal hamzaremmal changed the title fix: synthesis value of this.type in ValueOf fix: synthesise value of this.type in ValueOf May 3, 2025
@hamzaremmal hamzaremmal marked this pull request as ready for review May 3, 2025 11:37
EugeneFlesselle
EugeneFlesselle approved these changes May 3, 2025
View reviewed changes
Copy link
Contributor

@EugeneFlesselle EugeneFlesselle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamzaremmal hamzaremmal enabled auto-merge May 3, 2025 11:54
@hamzaremmal hamzaremmal merged commit 453f94d into scala:main May 3, 2025
28 checks passed
@hamzaremmal hamzaremmal deleted the i23086 branch May 3, 2025 12:29
@tgodzik tgodzik mentioned this pull request May 5, 2025
Merged
@WojciechMazur WojciechMazur added this to the 3.7.2 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneFlesselle EugeneFlesselle EugeneFlesselle approved these changes

Assignees

@EugeneFlesselle EugeneFlesselle

Labels
None yet
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.

Compiler fails to synthesize ValueOf for singleton this.type
3 participants
@hamzaremmal @EugeneFlesselle @WojciechMazur