Skip to content

Add missing version of ValDef.let which also accepts flags #23388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing version of ValDef.let which also accepts flags #23388

wants to merge 1 commit into from
+21 −0

Conversation

Kalin-Rudnicki
Copy link

@Kalin-Rudnicki Kalin-Rudnicki commented Jun 17, 2025 •
edited
Loading

Seems like a pretty straight forward one.

  • Theres a version of this in Symbol.newVal which accepts flags
  • The function downstream of this accepts flags, and all other ValDef.let are just passing EmptyFlags by way of default arg

@Kalin-Rudnicki
Copy link
Author

Not sure what the correct way to add this is so that it doesnt fail that bincompat test. Could use some advisement on that

@Kalin-Rudnicki Kalin-Rudnicki force-pushed the current/feature/let-with-flags branch from 3cc71be to acd09a3 Compare June 17, 2025 23:08
@tgodzik tgodzik requested a review from jchyb June 18, 2025 07:54
@jchyb jchyb added the needs-minor-release This PR cannot be merged until the next minor release label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchyb jchyb Awaiting requested review from jchyb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-minor-release This PR cannot be merged until the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kalin-Rudnicki @jchyb