-Yprofile-trace profiles all inline calls #23490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only profiled macro expansion, but even non-macro inline calls can have a significant impact on performance (e.g. if we're doing typeclass derivation) and are worth tracking. This does not seem to significantly impact the size of traces in practice.
WojciechMazur
approved these changes
Jul 8, 2025
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Jul 23, 2025
Previously we only profiled macro expansion, but even non-macro inline calls can have a significant impact on performance (e.g. if we're doing typeclass derivation) and are worth tracking. This does not seem to significantly impact the size of traces in practice. [Cherry-picked 8a14de3]
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Jul 24, 2025
Previously we only profiled macro expansion, but even non-macro inline calls can have a significant impact on performance (e.g. if we're doing typeclass derivation) and are worth tracking. This does not seem to significantly impact the size of traces in practice. [Cherry-picked 8a14de3]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only profiled macro expansion, but even non-macro inline calls can have a significant impact on performance (e.g. if we're doing typeclass derivation) and are worth tracking. This does not seem to significantly impact the size of traces in practice.