Change Nightly version date to be the current date in UTC #23819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wasn't the commit data also used to check if given version was already released? In such case we were not publishing new nightlies if there was no merges to main since the last (e.g. over the weekends) |
|
It was used to avoid publishing a nightly again if nothing was merged between two nightlies. Regardless, I prefer having the current day instead and we can use the hash to avoid publishing again. I'm merging this PR now. Thanks @natsukagami. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works better if the last commit doesn't belong to the same date as the build time.
[ ] Should we keep it in UTC, or use local time? It could happen that builder's machine is in a different timezone, and hence a different date.