Lint function arrow intended context function #23847
Merged
+62
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Sep 2, 2025
| private val WunstableInlineAccessors = BooleanSetting(WarningSetting, "WunstableInlineAccessors", "Warn an inline methods has references to non-stable binary APIs.") | ||
| private val WtoStringInterpolated = BooleanSetting(WarningSetting, "Wtostring-interpolated", "Warn a standard interpolator used toString on a reference type.") | ||
| private val WrecurseWithDefault = BooleanSetting(WarningSetting, "Wrecurse-with-default", "Warn when a method calls itself with a default argument.") | ||
| private val WdubiousContextual = BooleanSetting(WarningSetting, "Wdubious-contextual", "Warn about T ?=> (t: T) => U.") |
There was a problem hiding this comment.
Suggested change
| private val WdubiousContextual = BooleanSetting(WarningSetting, "Wdubious-contextual", "Warn about T ?=> (t: T) => U.") | |
| private val WunlikelyContextual = BooleanSetting(WarningSetting, "Wunlikely-contextual", "Warn about T ?=> (t: T) => U. when a normal function literal was used instead of context one."), |
just because the word is prone to typos for non english speakers and a bit more explanation aside from signature?
There was a problem hiding this comment.
I rely on -Xlint or now -Wall. Though I do like the word "dubious". All warnings are dubious because they begin with -W or "dubya".
som-snytt
force-pushed
the
issue/21187-contextual-func-lit
branch
from
4684bed to
f1d5ced
Compare
tgodzik
approved these changes
Sep 3, 2025
| private val WunstableInlineAccessors = BooleanSetting(WarningSetting, "WunstableInlineAccessors", "Warn an inline methods has references to non-stable binary APIs.") | ||
| private val WtoStringInterpolated = BooleanSetting(WarningSetting, "Wtostring-interpolated", "Warn a standard interpolator used toString on a reference type.") | ||
| private val WrecurseWithDefault = BooleanSetting(WarningSetting, "Wrecurse-with-default", "Warn when a method calls itself with a default argument.") | ||
| private val WdubiousContextual = BooleanSetting(WarningSetting, "Wwrong-arrow", "Warn if function arrow was used instead of context literal ?=>.") |
There was a problem hiding this comment.
Suggested change
| private val WdubiousContextual = BooleanSetting(WarningSetting, "Wwrong-arrow", "Warn if function arrow was used instead of context literal ?=>.") | |
| private val WwrongArrow = BooleanSetting(WarningSetting, "Wwrong-arrow", "Warn if function arrow was used instead of context literal ?=>.") |
| def unstableInlineAccessors(using Context): Boolean = allOr(WunstableInlineAccessors) | ||
| def toStringInterpolated(using Context): Boolean = allOr(WtoStringInterpolated) | ||
| def recurseWithDefault(using Context): Boolean = allOr(WrecurseWithDefault) | ||
| def dubiousContextual(using Context): Boolean = allOr(WdubiousContextual) |
There was a problem hiding this comment.
Suggested change
| def dubiousContextual(using Context): Boolean = allOr(WdubiousContextual) | |
| def wrongArrow(using Context): Boolean = allOr(WdubiousContextual) |
|
Thanks! |
HarrisL2
pushed a commit
to HarrisL2/scala3
that referenced
this pull request
Sep 12, 2025
Fixes scala#21187 If a function literal `x => body` has an expected type `X ?=> ?` then maybe they intended to write `x ?=> body`. As shown in the test, maybe types will misalign in other ways to emit warnings.
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Sep 12, 2025
Fixes scala#21187 If a function literal `x => body` has an expected type `X ?=> ?` then maybe they intended to write `x ?=> body`. As shown in the test, maybe types will misalign in other ways to emit warnings.
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Sep 12, 2025
Fixes scala#21187 If a function literal `x => body` has an expected type `X ?=> ?` then maybe they intended to write `x ?=> body`. As shown in the test, maybe types will misalign in other ways to emit warnings. [Cherry-picked e0ff329][modified]
WojciechMazur
pushed a commit
that referenced
this pull request
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21187
If a function literal
x => bodyhas an expected typeX ?=> ?then maybe they intended to writex ?=> body.As shown in the test, maybe types will misalign in other ways to emit warnings.