-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Enable exhaustivity and reachability checks for opaque types #23909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nox213
wants to merge
1
commit into
scala:main
Choose a base branch
from
nox213:fix/i23620
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
trait Foo | ||
trait Bar | ||
|
||
type FooOrBar = FooOrBar.Type | ||
object FooOrBar: | ||
opaque type Type <: (Foo | Bar) = Foo | Bar | ||
|
||
def bar: FooOrBar = new Bar {} | ||
|
||
trait Buz | ||
|
||
@main def main = | ||
val p: FooOrBar | Buz = FooOrBar.bar | ||
|
||
p match | ||
case _: Foo => println("foo") | ||
case _: Buz => println("buz") | ||
case _: Bar => println("bar") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
-- [E029] Pattern Match Exhaustivity Warning: tests/warn/i23620b.scala:20:2 -------------------------------------------- | ||
20 | p match // warn | ||
| ^ | ||
| match may not be exhaustive. | ||
| | ||
| It would fail on pattern case: _: Bar | ||
| | ||
| longer explanation available when compiling with `-explain` | ||
-- [E029] Pattern Match Exhaustivity Warning: tests/warn/i23620b.scala:23:2 -------------------------------------------- | ||
23 | p2 match { //warn | ||
| ^^ | ||
| match may not be exhaustive. | ||
| | ||
| It would fail on pattern case: _: Bar | ||
| | ||
| longer explanation available when compiling with `-explain` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
trait Foo | ||
trait Bar | ||
|
||
type FooOrBar = FooOrBar.Type | ||
object FooOrBar: | ||
opaque type Type <: (Foo | Bar) = Foo | Bar | ||
|
||
def bar: FooOrBar = new Bar {} | ||
|
||
type OnlyFoo = OnlyFoo.Type | ||
object OnlyFoo: | ||
opaque type Type <: (Foo | Bar) = Foo | ||
|
||
def foo: OnlyFoo = new Foo {} | ||
|
||
@main def main = | ||
val p: FooOrBar= FooOrBar.bar | ||
val p2: OnlyFoo = OnlyFoo.foo | ||
|
||
p match // warn | ||
case _: Foo => println("foo") | ||
|
||
p2 match { //warn | ||
case _: Foo => println("foo") | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I extract this logic into a separate function? If so, where would be a good place to put it?