Only nullfiy simple kinded types #23911
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this PR was initiated on top of the wrong branch. Please rebase on top of |
noti0na1
requested changes
Sep 12, 2025
| || tp.isRef(defn.UnitClass) | ||
| // We don't modify `Any` because it's already nullable. | ||
| || tp.isRef(defn.AnyClass) => false | ||
| case tp: TypeParamRef if !tp.hasSimpleKind => false |
There was a problem hiding this comment.
!tp.hasSimpleKind can be moved to the first if together with outermostLevelAlreadyNullable.
| case tp: TypeRef if !tp.hasSimpleKind | ||
| // We don't modify value types because they're non-nullable even in Java. | ||
| || tp.symbol.isValueClass | ||
| || tp.isRef(defn.NullClass) |
There was a problem hiding this comment.
We may also need to consider the following special classes: SingletonClass, AnyKindClass, FromJavaObjectSymbol, etc...
| val n1: List[Map[String, Int]] = ??? | ||
| val n2 = new N[List]() | ||
| val n3 = n2.accept[Any](n1) | ||
|
|
There was a problem hiding this comment.
Let's also test some type lambdas like [X] =>> R
|
Closed as subsumed by #23938 |
noti0na1
added a commit
that referenced
this pull request
Sep 22, 2025
…llification rules (#23938) Given the nightly results, we think the nullification rules still need some polish and is not ready for all compiled Scala code. Hence, we only nullify tasty if `Ynullify-tasty` is set now. Based on #23911 Fixes #23908 Could fix #23933, #23935, #23936, and #23937 (I tested locally due the explicit nulls tests disabled temprarily)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests may be needed
Fixes #23908