-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Standard Library Sync: September 24th, 2025 #24063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Comment on private ListBuffer.locate [ci: last-only]
…sage Use List.fill instead of range [ci: last-only]
…array IterableOnce#copyToArray uses helper for count [ci: last-only]
This fixes scala/scala#13108 when comparing Seq[Float] with Seq[Float] it expected that Float.NaN != Float.NaN and 0.0 equals -0.0f. But before this patch this was violated by ArraySeq.ofFloat/ofDouble
Fix ArraySeq.ofFloat/ofDouble.equals for floating point
Extract branches to be mostly dependent on `isInclusive` and `step >= 0`. These are often constant, and when they're not statically constant, they are probably predictable anyway. This commit upstreams scala-js/scala-js@a5337ed from Scala.js.
Previously, `Range` used a number of intermediate operations on `Long`s to avoid overflow. We can streamline a lot of code by using unsigned `Int` arithmetics. In particular, there is only 1 division in the initialization path, instead of 3. Although the fields have not changed, the content of `numRangeElements` is more strict for overfull ranges. This means that deserializing an overfull range from a previous version would not be safe. This is why we bump the SerialVersionUID. This commit upstreams scala-js/scala-js@d972218 from Scala.js.
Avoid evaluating `value0` twice on completed Futures for performance.
perf: avoid double checking `value0` Future.
Some merge commits show up ( What is unfortunate here is that navigating the history of a change will become a lot more difficult. In a few years, if someone wonders about the history of e8534ef (for example), how would they find their way from there to discussion on scala/scala#11098? Amending the commit messages to link to the original commit on scala/scala (scala/scala@bd6bdf8 in this case) would solve it. But I assume that ship has sailed for the library history that is already in scala/scala3 today? |
Oh, that is unfortunate, indeed. I never thought about that.
No ship has ever truly sailed in git land. But in this case, the cost of fixing it probably exceeds what any of us is willing to spend in git hackery. In particular it would mean rewriting the history of scala3/main since the first merge with new SHAs. One mitigation would be to expose an external index of corresponding commits, that we could look up manually. |
Superseed #24062
Steps to reproduce: