Tweak tryParameterless to use readapt #24078
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readapt will autoapply if permitted and also warn on migration.
Fixes #21207
Why was the ticket worth tackling?
I started to look at tickets about overloading, so this is a first step on the journey of understanding the parts involved.
It happens that I backported
tryParameterless
to Scala 2.How I fixed it
There are just two places where it adds parens.
My first attempt was more direct, since I want only a possible warning and parens:
but the tree has an overloaded type.
Why is this PR worth reviewing?
It's a one-line change, so now I'm on pace for 1 LOC/day, which is net zero.
What's the worse that could happen?
The fix is a bit indirect, so it's easy to imagine it breaking under strain.