Skip to content

Conversation

hamzaremmal
Copy link
Member

:)

@mbovel mbovel self-requested a review October 1, 2025 13:11
Copy link
Member

@mbovel mbovel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems dubious to duplicate the definition of scalac and testCompilation at two places; can't we factor these out? 🥺

@hamzaremmal
Copy link
Member Author

hamzaremmal commented Oct 1, 2025

Seems dubious to duplicate the definition of scalac and testCompilation at two places; can't we factor these out? 🥺

I know, I know. I just duplicated everything when I migrated things because a lot of things are happening everywhere so that when we migrated, I know what happens where, why and how. This build is complex enough already and I want to understand what is happening.

@hamzaremmal hamzaremmal marked this pull request as ready for review October 1, 2025 13:20
@hamzaremmal hamzaremmal requested a review from Gedochao October 1, 2025 13:20
@hamzaremmal hamzaremmal enabled auto-merge October 1, 2025 15:50
@hamzaremmal hamzaremmal merged commit b7cae74 into scala:main Oct 1, 2025
44 checks passed
@hamzaremmal hamzaremmal deleted the sbt-aliases branch October 1, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants