Skip to content

Fix compiler crash with -Ymagic-offset-header #24124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2025
+4 −4
Merged

Fix compiler crash with -Ymagic-offset-header #24124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ac4db2
.
lihaoyi Oct 2, 2025
55b470f
.
lihaoyi Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler/src/dotty/tools/dotc/ast/Positioned.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@ abstract class Positioned(implicit @constructorOnly src: SourceFile) extends Src
def sourcePos(using Context): SourcePosition =
val info = WrappedSourceFile.locateMagicHeader(source)
info match
case HasHeader(offset, originalFile) =>
if span.start >= offset then // This span is in user code
// This span is in user code
case HasHeader(offset, originalFile)
if span.exists && span.start >= offset =>
originalFile.atSpan(span.shift(-offset))
else // Otherwise, return the source position in the wrapper code
source.atSpan(span)
// Otherwise, return the source position in the wrapper code
case _ => source.atSpan(span)

/** This positioned item, widened to `SrcPos`. Used to make clear we only need the
Expand Down
Loading