Copy CDN css and js to local resources #2469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
May 19, 2017
|
Forgot to add the css/js files themselves to the PR? :) |
|
There are tests for the site structure in |
Geez! Will do, along with the tests |
|
Done! |
felixmulder
reviewed
May 19, 2017
| ></script> | ||
| <script src="{{ site.baseurl }}/js/jquery.min.js"></script> | ||
| <script src="{{ site.baseurl }}/js/tether.min.js"></script> | ||
| <script src="{{ site.baseurl }}/js/bootstrap.pack.js"></script> |
There was a problem hiding this comment.
You're mentioning bootstrap.pack.js, but you've added bootstrap.min.js as a file. Highlight js is entirely missing
EDIT: scratch the highlight part, it's already in the repo :)
There was a problem hiding this comment.
Extremely sorry, noticed it just now. I've pushed an update.
|
Thanks @Varunram! 🎉 |
|
Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended as a fix for #1949