Skip to content

Add include for rendering sidebar in docs #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2017
Merged

Add include for rendering sidebar in docs #2608

merged 2 commits into from
May 30, 2017

Conversation

felixmulder
Copy link
Contributor

This fix mirrors the sidebar in docs/index.md by include. Maybe we should consider renaming sidebar.yml => toc.yml or something similar. But later PR.

I was rebooked to 15:30 :(

So still hacking, but boarding is starting...

@felixmulder felixmulder requested a review from smarter May 30, 2017 13:15
smarter
smarter approved these changes May 30, 2017
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with this new ordering, you have to scroll to see the "Usage" section, I suggest moving it before the "Reference" section. Also maybe use a different font style for the section names?

@felixmulder felixmulder merged commit 9366528 into scala:master May 30, 2017
@allanrenucci allanrenucci deleted the topic/add-toc branch December 14, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixmulder @smarter