Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2514: Survive non-sensical trees in Typer #2752

Merged
merged 4 commits into from
Jun 14, 2017

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jun 14, 2017

Two problems here, because of previous parsing errors

  • We encounter a TypeTree() without expected type
  • We encounter a ValDef as an argument of an AppliedTypeTree

Two problems here, because of previous parsing errors

 - We encounter a TypeTree() without expected type
 - We encounter a ValDef as an argument of an AppliedTypeTree
@odersky
Copy link
Contributor Author

odersky commented Jun 14, 2017

In fact, the example looks sensible, so we should be able to parse it. That's for another PR though.

That "varargs" syntax T* was classified as a term tree, but it should be a type tree.
Play with Result and Try types. Piggybacked here.
@DarkDimius DarkDimius merged commit 8ddfcaf into scala:master Jun 14, 2017
@allanrenucci allanrenucci deleted the fix-#2514-2 branch December 14, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants