Fix #2677: Fix type of super selection #2757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List union is clearly wrong, as it is simply the same as ++.
It used to return the joint denotation, but the correct answer is the denotation of the symbol in the joint denotation as seen from the super prefix.
smarter
reviewed
Jun 14, 2017
| @@ -394,7 +394,10 @@ object Types { | |||
| case tp: ClassInfo => | |||
| tp.cls.baseClasses | |||
| case AndType(tp1, tp2) => | |||
| tp1.baseClasses union tp2.baseClasses | |||
There was a problem hiding this comment.
Seems like a good reason to not have union be defined on List :)
|
Replaced by #2768. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related fix: base classes (i.e. linearization) of AndTypes.