Harden IDE some more #2787
Merged
Harden IDE some more #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Jun 20, 2017
| // in case of errors it may be that typed trees point to untyped ones. | ||
| // The can still traverse inside such trees, either in the run where errors |
There was a problem hiding this comment.
Missing word between "The" and "can"?
smarter
reviewed
Jun 20, 2017
| @@ -1538,7 +1538,8 @@ object Types { | |||
| else recomputeMember(d) // symbol could have been overridden, recompute membership | |||
| else { | |||
| val newd = loadDenot | |||
| if (newd.exists) newd else d.staleSymbolError | |||
| if (newd.exists || ctx.mode.is(Mode.Interactive)) newd | |||
There was a problem hiding this comment.
Isn't this going to fail with a NoDenotation error later on? If you really want to return the old denotation this should be d, not newd
smarter
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across two more sources of crashes when doing heavy editing on Types.scala
tpd.TreeAccumulator hit again an untyped tree. I believe this is because the tree was left in because of an error in a previous run. Because the error was in a previous run, we cannot take
reporter.hasErrorsas a test to avoid the crash.I got a StaleSymbolError through another path as before.