More tweaks to harden IDE #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We observed a crash in ensureConforms when running the IDE because the expected type was not a value type.
I observed assertion failures, that a param ref is not in the current constraint. Avoiding an assertion failure if that case is encountered in the IDE.
Crash was observed where the assert is.
The underlying machinery has various ways to throw a TypeError. I observed a MergeError when accidentally writing the same method twice. CyclicReferences are also possible. These should not lead to crashes to the presentation compiler.
smarter
approved these changes
Jul 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all lifted out of the pattern matcher PR, to be reviewed separately.