Skip to content

Conversation

nicolasstucki
Copy link
Contributor

In this implementation the first parameter of the
value class must be a subtype of scala.Any. Every
other parameter must be phantom.

In this implementation the first parameter of the
value class must be a subtype of scala.Any. Every
other parameter must be phantom.
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ctx.error("value class parameter must not be phantom", param.pos)
case _ =>
ctx.error(ValueClassNeedsExactlyOneValParam(clazz), clazz.pos)
ctx.error("value class first parameter must not be phantom.", param.pos)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra .

@allanrenucci allanrenucci merged commit b36c9be into scala:master Sep 5, 2017
@allanrenucci allanrenucci deleted the phantoms-in-value-classes branch December 14, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants