Skip to content

Make the Tasty hash branchless #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Conversation

smarter
Copy link
Member

@smarter smarter commented Oct 4, 2017

No description provided.

@smarter smarter requested a review from sjrd October 4, 2017 21:10
@smarter
Copy link
Member Author

smarter commented Oct 4, 2017

test performance please

@dottybot
Copy link
Member

dottybot commented Oct 4, 2017

performance test scheduled: 15 job(s) in queue, 1 running.

Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it's obviously equivalent.

@DarkDimius
Copy link
Contributor

I'm curious: any measurable difference?

@smarter
Copy link
Member Author

smarter commented Oct 4, 2017

Hi @DarkDimius ! Not sure yet, we'll see what the benchmark results are in a few hours :).

@dottybot
Copy link
Member

dottybot commented Oct 5, 2017

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3261/ to see the changes.

Benchmarks is based on merging with master (4aa13b0)

@odersky odersky merged commit 543b697 into scala:master Oct 5, 2017
@allanrenucci allanrenucci deleted the branchless-hash branch December 14, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants