Fix generic signatures of generic methods #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Oct 31, 2017
| // phantom method parameters do not make it to the bytecode. | ||
| val params = mtpe.paramInfos.filterNot(_.isPhantom) | ||
| val restpe = mtpe.resultType | ||
| val params = allParamTypes(mtpe).filterNot(_.isPhantom) |
There was a problem hiding this comment.
That's much better, thanks.
nicolasstucki
approved these changes
Oct 31, 2017
|
Btw, the convention for the commit message fixing a bug would be |
We ignored the case where a `MethodType` had another `MethodType` as result type. This commit fixes the issue by collecting the parameters of the result type if it is a `MethodType`, recursively. Fixes scala#3411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignored the case where a
MethodTypehad anotherMethodTypeasresult type. This commit fixes the issue by collecting the parameters of
the result type if it is a
MethodType, recursively.Fixes #3411