Skip to content

Fix typo in implicit conversion example #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2017
Merged

Fix typo in implicit conversion example #3650

merged 1 commit into from
Dec 10, 2017

Conversation

nerush
Copy link
Contributor

@nerush nerush commented Dec 10, 2017

In the following example:

def useConversion(implicit f: A => B) = {
      val y: A = ...
      val x: B = a    // error under Dotty
}

x should probably refer to y, but not to a

@nerush
Fix typo in implicit conversion example
82b5604 
In the following example:

def useConversion(implicit f: A => B) = {
      val y: A = ...
      val x: B = y    // error under Dotty
}

`x` should probably refer to `y`, but not to `a`
dottybot
dottybot reviewed Dec 10, 2017
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

allanrenucci
allanrenucci approved these changes Dec 10, 2017
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @nerush!

@allanrenucci allanrenucci merged commit 18f56fe into scala:master Dec 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

+1 more reviewer

@allanrenucci allanrenucci allanrenucci approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nerush @allanrenucci @dottybot