Skip to content

Fix impure by name macro parameters #4491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2018
Merged

Fix impure by name macro parameters #4491

merged 3 commits into from
May 22, 2018

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

Blaisorblade
Blaisorblade previously approved these changes May 9, 2018
View reviewed changes
@Blaisorblade
Copy link
Contributor

Code change LGTM, feel free to wait for better reviews :-).

@nicolasstucki nicolasstucki dismissed Blaisorblade’s stale review May 11, 2018 13:19

I need to change something

@biboudis biboudis self-requested a review May 16, 2018 12:05
biboudis
biboudis approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @nicolasstucki

@nicolasstucki nicolasstucki merged commit fabd65d into scala:master May 22, 2018
@allanrenucci allanrenucci deleted the fix-quote-stuff branch May 22, 2018 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBlanvillain OlivierBlanvillain Awaiting requested review from OlivierBlanvillain

2 more reviewers

@biboudis biboudis biboudis approved these changes

@Blaisorblade Blaisorblade Blaisorblade left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@OlivierBlanvillain OlivierBlanvillain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasstucki @Blaisorblade @biboudis @OlivierBlanvillain