Skip to content

Fix incremental compilation under Java 8 #5061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Fix incremental compilation under Java 8 #5061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions project/Build.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import dotty.tools.sbtplugin.DottyIDEPlugin.autoImport._
import sbtbuildinfo.BuildInfoPlugin
import sbtbuildinfo.BuildInfoPlugin.autoImport._

import scala.util.Properties.isJavaAtLeast

/* In sbt 0.13 the Build trait would expose all vals to the shell, where you
* can use them in "set a := b" like expressions. This re-exposes them.
*/
Expand Down Expand Up @@ -225,6 +227,14 @@ object Build {
// non-bootstrapped dotty-library that will then take priority over
// the bootstrapped dotty-library on the classpath or sourcepath.
classpathOptions ~= (_.withAutoBoot(false)),
// ... but when running under Java 8, we still need a Scala bootclasspath that contains the JVM bootclasspath,
// otherwise sbt incremental compilation breaks.
scalacOptions ++= {
if (isJavaAtLeast("9"))
Seq()
else
Seq("-bootclasspath", sys.props("sun.boot.class.path"))
},

// Enforce that the only Scala 2 classfiles we unpickle come from scala-library
/*
Expand Down