Add sourceCode to TASTy reflect Position #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexarchambault could you have a look at this to see if it is enough for the sourcecode macros. |
liufengyun
approved these changes
Feb 8, 2019
Partial fix for scala#5782: * get the ~raw code of arguments of the root context (in `def foo(s: Seq[Int])(implicit foo: Foo)`, with the implicit materialization of `Foo` backed by a macro - how can the macro get a String `"(1 to 10).sum"` in `f((1 to 10).sum)`?). Prevents to have `sourcecode.Text` work fine.
nicolasstucki
force-pushed
the
tasty-reflect-get-source-at-position
branch
from
0c09917
to
c6876ff
Compare
|
Currently, the positions of nested trees are wrong. I added #5904 to track this other issue. |
ghost
removed
the
alexarchambault
added a commit
to alexarchambault/sourcecode
that referenced
this pull request
Mar 13, 2019
alexarchambault
added a commit
to alexarchambault/sourcecode
that referenced
this pull request
Mar 13, 2019
alexarchambault
added a commit
to alexarchambault/sourcecode
that referenced
this pull request
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #5782:
def foo(s: Seq[Int])(implicit foo: Foo), with the implicit materialization ofFoobacked by a macro - how can the macro get a String"(1 to 10).sum"inf((1 to 10).sum)?). Prevents to havesourcecode.Textwork fine.