Skip to content

Fix #5954: Do not check prefix for non locally defined types #5961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Fix #5954: Do not check prefix for non locally defined types #5961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90f4d5b
Fix #5954: Do not check prefix for non locally defined types
nicolasstucki Feb 21, 2019
e277ff2
Add regression test
nicolasstucki Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/src/dotty/tools/dotc/transform/Staging.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,8 @@ class Staging extends MacroTransform {
*/
private def checkSymLevel(sym: Symbol, tp: Type, pos: SourcePosition)(implicit ctx: Context): Option[Tree] = {
val isThis = tp.isInstanceOf[ThisType]
if (!isThis && sym.maybeOwner.isType && !sym.is(Param))
checkSymLevel(sym.owner, sym.owner.thisType, pos)
if (!isThis && !sym.is(Param) && sym.maybeOwner.isType)
None
else if (sym.exists && !sym.isStaticOwner && !levelOK(sym))
tryHeal(sym, tp, pos)
else
Expand Down
10 changes: 10 additions & 0 deletions tests/neg/i5954.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
abstract class MatcherFactory1 {
class AndNotWord
}

object MatcherFactory1 {
import scala.quoted._

def impl2(a: MatcherFactory1)(self: Expr[a.AndNotWord]) =
'{ ~self } // error: access to value a from wrong staging level
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how we can use a properly in such context? We need to have some principles to deal with terms in types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could encode with something like

def impl2[T: Type](a: MatcherFactory1)(self: Expr[T])(implicit ev: T =:= a.AndNotWord) = ...

15 changes: 15 additions & 0 deletions tests/pos/i5954.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
abstract class MatcherFactory1 {
class AndNotWord
}

object MatcherFactory1 {
import scala.quoted._

def impl(self: Expr[MatcherFactory1#AndNotWord]) =
'{ ~self }


def impl2[T: Type](a: MatcherFactory1)(self: Expr[T])(implicit ev: T =:= a.AndNotWord) =
'{ ~self }

}