Skip to content

Conversation

smarter
Copy link
Member

@smarter smarter commented Apr 22, 2019

Running "find all references" in Dotty itself used to fail because
constructing the map of project to their dependency failed, because this
map is based on the projectDependencies key written in
.dotty-ide.json which might contain projects which are not loaded in
the IDE because they were excluded with excludeFromIDE.
This commit fixes this by just ignoring dependencies which do not
correspond to projects loaded in the IDE, this is the most resilient
way to fix this.

Running "find all references" in Dotty itself used to fail because
constructing the map of project to their dependency failed, because this
map is based on the `projectDependencies` key written in
`.dotty-ide.json` which might contain projects which are not loaded in
the IDE because they were excluded with `excludeFromIDE`.
This commit fixes this by just ignoring dependencies which do not
correspond to projects loaded in the IDE, this is the most resilient
way to fix this.
@nicolasstucki nicolasstucki merged commit 94813ac into scala:master Apr 23, 2019
@nicolasstucki nicolasstucki deleted the fix-find-all-refs branch April 23, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants