Fix #6585: implement Type.isFunctionType in tasty reflect API #6586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
commented
May 29, 2019
| * @note `List[Int]` is not a function type, despite that `List[Int] <:< Int => Int`. | ||
| */ | ||
| def Type_isFunctionType(self: Type)(implicit ctx: Context): Boolean | ||
|
|
There was a problem hiding this comment.
The specification of the method may raise some concerns. However, in the setting of meta-programming, this is can be justified, as it's well-known that reflection breaks referential transparency. E.g. 1 + 1 == 2, but '{1 + 1} != '2. For this method, the semantic reasoning breaks at the type level -- an intended effect that's useful in meta-programming.
nicolasstucki
suggested changes
May 30, 2019
…isDependentFunctionType
nicolasstucki
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6585: implement Type.isFunctionType in tasty reflect API