Skip to content

Fix #6676: Add missing buffer bound check #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Fix #6676: Add missing buffer bound check #6696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion compiler/src/dotty/tools/dotc/parsing/Parsers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,10 @@ object Parsers {
private def interpolatedString(inPattern: Boolean = false): Tree = atSpan(in.offset) {
val segmentBuf = new ListBuffer[Tree]
val interpolator = in.name
val isTripleQuoted = in.buf(in.charOffset) == '"' && in.buf(in.charOffset + 1) == '"'
val isTripleQuoted =
in.charOffset + 1 < in.buf.length &&
in.buf(in.charOffset) == '"' &&
in.buf(in.charOffset + 1) == '"'
in.nextToken()
def nextSegment(literalOffset: Offset) =
segmentBuf += Thicket(
Expand Down
25 changes: 25 additions & 0 deletions compiler/test-resources/repl/i6676
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
scala> xml"
1 | xml"
| ^
| unclosed string literal
1 | xml"
| ^
| ';' expected, but eof found
scala> xml""
1 | xml""
| ^
|value xml is not a member of StringContext - did you mean StringContext.s?
scala> xml"""
1 | xml"""
| ^
| unclosed multi-line string literal
1 | xml"""
| ^
| unclosed multi-line string literal
scala> s"
1 | s"
| ^
| unclosed string literal
1 | s"
| ^
| ';' expected, but eof found