Use some enums in compiler #6733
Conversation
|
There are actually surprisingly few opportunities to use enums. The problem is that most simple enumerations we use in the compiler have bitset structure. So an enum does not work for them, at least |
|
The last one that could be a Scala enum is |
|
Is it not possible to add |
|
We also need stable IDs which an ordering would not give. |
|
I was hoping it would use the enum's ordinal? still doesn't know how |
|
We could use a derived ordering for these. But for the moment using a couple |
|
The remaining failures have to do with -Ytest-pickler instabilities of positions of Child annotations (fixed in #6752). I'm putting this PR on hold until the next bootstrap compiler is out that fixes the problem. |
odersky
force-pushed
the
refactor-use-enums
branch
from
a29edc4 to
f54266b
Compare
| @@ -217,7 +213,7 @@ object desugar { | |||
| val meth @ DefDef(_, tparams, vparamss, tpt, rhs) = transformQuotedPatternName(meth0) | |||
| val methName = normalizeName(meth, tpt).asTermName | |||
| val mods = meth.mods | |||
| val epbuf = new ListBuffer[ValDef] | |||
| val epbuf = ListBuffer[ValDef]() | |||
There was a problem hiding this comment.
ListBuffer[ValDef] is unambiguous. Meaning there is no question whether it is a reference to an object or a constructor call here because of the type parameters. Can we drop () here in future?
No description provided.