Use more union types in compiler #6744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jun 25, 2019
dwijnand
force-pushed
the
use-more-union-types
branch
from
9a3fb34 to
1805c22
Compare
odersky
approved these changes
Jun 26, 2019
| (tickedString, alt) | ||
| } | ||
| } | ||
| res // help the inferrencer out |
There was a problem hiding this comment.
What went wrong here? Should we open as issue for this?
There was a problem hiding this comment.
I don't know, but I opened #6751 for you.
There was a problem hiding this comment.
Ah I see, widening of union types.
odersky
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #6728.