Skip to content

Fix extension method while compiling for documentation in CI #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2019
Merged

Fix extension method while compiling for documentation in CI #6951

merged 1 commit into from
Jul 28, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki requested a review from liufengyun July 28, 2019 07:34
liufengyun
liufengyun approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 6d64440 into scala:master Jul 28, 2019
@nicolasstucki nicolasstucki deleted the fix-extension-method-under-documentation branch July 28, 2019 12:22
@nicolasstucki
Copy link
Contributor Author

The fix worked as expected https://dotty-ci.epfl.ch/lampepfl/dotty/408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun