Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out staging from the core of scala.quoted #7077

Merged
merged 3 commits into from Aug 22, 2019
Merged

Factor out staging from the core of scala.quoted #7077

merged 3 commits into from Aug 22, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Aug 21, 2019 •
edited

Move run and Toolbox to scala.quoted.staging.

Usage

import scala.quoted.staging._

delegate for Toolbox = Toolbox.make(getClass.getClassLoader)

run {
  val expr = '{ ... }
  expr
}

@nicolasstucki nicolasstucki self-assigned this Aug 21, 2019
@nicolasstucki nicolasstucki force-pushed the factor-out-staging-from-the-core-of-scala.quoted branch 3 times, most recently from 488117c to a904dfb Compare August 21, 2019 11:02
@nicolasstucki nicolasstucki force-pushed the factor-out-staging-from-the-core-of-scala.quoted branch from a904dfb to ac55aab Compare August 21, 2019 11:43
@nicolasstucki nicolasstucki marked this pull request as ready for review August 21, 2019 12:21
@nicolasstucki nicolasstucki mentioned this pull request Aug 21, 2019
Merged
liufengyun
liufengyun approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit a14180f into scala:master Aug 22, 2019
@nicolasstucki nicolasstucki deleted the factor-out-staging-from-the-core-of-scala.quoted branch August 22, 2019 13:41
@anatoliykmetyuk anatoliykmetyuk added this to the 0.18 Tech Preview milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
0.18 Tech Preview
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolasstucki @liufengyun @anatoliykmetyuk