Release sbt-dotty 0.3.4, future-proof isDotty #7120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It failed once on the CI on OpenJDK 8 because the toString of the exception was "java.lang.ArrayIndexOutOfBoundsException" instead of "java.lang.ArrayIndexOutOfBoundsException:-1" (https://dotty-ci.epfl.ch/lampepfl/dotty/982/1/4). I have no idea how this could happen (different code paths between the interpreted and JIT compiled code ?), so just stop checking for the exact toString output.
smarter
force-pushed
the
sbt-dotty-0.3.4
branch
from
863a67f
to
bcbbbc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a released sbt-dotty with f5459d0#diff-2341add22275f228b7ecd69d80025b8a in.
I'm doing the sbt-dotty release manually as usual by running:
drone build promote lampepfl/dotty $BUILD_ID sbt_release