Skip to content

Fix #7119: Don't infer given arguments if explicit ones are given #7141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2019
Merged

Fix #7119: Don't infer given arguments if explicit ones are given #7141

merged 1 commit into from
Sep 3, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 30, 2019

Don't infer given arguments if explicit ones are given, even if the
explicit arguments are part of an IgnoredProto.

@odersky
Fix scala#7119: Don't infer given arguments if explicit ones are given
267701d 
Don't infer given arguments if explicit ones are given, even if the
explicit arguments are part of an IgnoredProto.
@odersky odersky requested a review from biboudis August 30, 2019 15:15
biboudis
biboudis reviewed Sep 2, 2019
View reviewed changes
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add a comment in adapt for handling extension methods?

@biboudis biboudis merged commit d36e458 into scala:master Sep 3, 2019
@biboudis biboudis deleted the fix-#7119 branch September 3, 2019 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@biboudis biboudis biboudis left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@biboudis biboudis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @biboudis