Skip to content

0.19.0-RC1 Blog Article #7269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2019
Merged

0.19.0-RC1 Blog Article #7269

merged 1 commit into from
Sep 23, 2019

Conversation

anatoliykmetyuk
Copy link
Contributor

No description provided.

@smarter smarter mentioned this pull request Sep 19, 2019
Merged
@TheElectronWill
Copy link
Contributor

TheElectronWill commented Sep 20, 2019 •
edited
Loading

Section on the Dottydoc redesign (feel free to edit if needed):

Dottydoc redesign

The output of Dottydoc has been redesigned. It is now fully responsive: every element, including API docs and search, is adapted to both small and big screens.

The most visible changes are the toolbar and the sidebar. They now have a common darker background, which makes them more readable and helps separating navigation from content. Also, the sidebar is collapsible and has been optimized so that it doesn't glitch when the page loads.

The toolbar's logo can now be set with the -project-logo option.
For instance, -project-logo dotty-logo.svg will make /images/dotty-logo.svg appear in the toolbar.

The front page has been redesigned too, with a new responsive menu and improved contrast.

Overall, every page has been updated with consistent settings of fonts and colors. A more detailed comparison between the new and the old design can be found here.

@anatoliykmetyuk
Copy link
Contributor Author

Thank you @TheElectronWill, your help is much appreciated.

odersky
odersky approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end it's better not to wait for #7220 and #7276. It would be too risky to merge them at the present time.

So, please go ahead with the release as is.

@anatoliykmetyuk
Copy link
Contributor Author

Ok, I've started the release.

biboudis
biboudis approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@biboudis biboudis assigned anatoliykmetyuk and unassigned biboudis Sep 23, 2019
@anatoliykmetyuk anatoliykmetyuk merged commit d4d0a21 into scala:master Sep 23, 2019
@anatoliykmetyuk anatoliykmetyuk deleted the blog-rc-19 branch September 23, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

+2 more reviewers

@nicolasstucki nicolasstucki nicolasstucki left review comments

@biboudis biboudis biboudis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@anatoliykmetyuk anatoliykmetyuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anatoliykmetyuk @TheElectronWill @biboudis @odersky @nicolasstucki