Skip to content

Add scala-xml to classpath in dotc script #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DarkDimius
Copy link
Contributor

fix for #73

@DarkDimius
Copy link
Contributor Author

@retronym @sjrd please review

@retronym
Copy link
Member

Maybe you want to bump to 2.11.0-rc2 and XML 1.0.0 while you are at it. Otherwise LGTM

@sjrd
Copy link
Member

sjrd commented Mar 17, 2014

LGTM, although I would prefer that the compiler did not depend on scala-xml.jar not to crash ...

@odersky
Copy link
Contributor

odersky commented Mar 17, 2014

Yes, let's work to make the compiler run without scala-xml.

@odersky
Copy link
Contributor

odersky commented Mar 19, 2014

I believe this can be closed now, because we made dotc not depend on xml anymore. Correct?

@DarkDimius DarkDimius closed this Mar 19, 2014
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request Mar 19, 2025
Backport "Add missing error messages to asserts in QuotesImpl" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants