Fix #8632: Reveal "not found" message more often #8638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
changed the title
If a creator expression is tried, we want to make sure we see a "not found" message, so that we fall back in this case to reporting the original select failure. To this purpose - we check for stable path prefixes after doing the selection proper - we recognize leading not found messages also if they are following by other messages
|
I changed the commit message |
smarter
approved these changes
Mar 30, 2020
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 8, 2020
In particular, this contains scala#8638 which avoids getting some confusing error messages.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Apr 8, 2020
In particular, this contains scala#8638 which avoids getting some confusing error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a creator expression is tried, we want to make sure we see a "not found" message,
so that we fall back in this case to reporting the original select failure. To this
purpose