Fix #8922: Performance tweak for space computation #8928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We first substract the last pattern, usually it's a wildcard, thus speeds up computation. In computing `Prod(K, a1, a2, ..) - Prod(K, b1, b2, ..)`, if there exists one dimension that is not reducible, i.e. `a_i < a_i - b_i`, then the result is just `Prod(K, a1, a2, ..)`.
Useful for the following test: tests/run-custom-args/tuple-cons.scala
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/8928/ to see the changes. Benchmarks is based on merging with master (5154641) |
|
|
|
The S test and T test they have different ordering: the T has more general patterns at the end, while S has the general patterns at the beginning. In this PR, we process the patterns backwards, thus |
nicolasstucki
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first subtract the last pattern, usually, it's a wildcard, thus speeds up computation.
In computing
Prod(K, a1, a2, ..) - Prod(K, b1, b2, ..), if there exists one dimension that isnot reducible, i.e.
a_i < a_i - b_i, then the result is justProd(K, a1, a2, ..).Fixes #8922, #7186