Skip to content

Fix #9186: Only warn when the path cannot be relativized #9188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2020
Merged

Fix #9186: Only warn when the path cannot be relativized #9188

merged 1 commit into from
Jun 16, 2020

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki marked this pull request as ready for review June 16, 2020 14:21
@nicolasstucki nicolasstucki requested a review from liufengyun June 16, 2020 14:21
@nicolasstucki
Copy link
Contributor Author

Also see #9186 (comment)

liufengyun
liufengyun approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 7349d7f into scala:master Jun 16, 2020
@nicolasstucki nicolasstucki deleted the fix-#9186 branch June 16, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun