Increase import suggestion timeout in tests #9196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tests/neg/missing-implicit1.scala` can easily have a different (but correct) output when the CI is overloaded.
|
For example https://github.com/lampepfl/dotty/runs/780835136 |
nicolasstucki
added
the
fasttrack
|
The errors arise since now the import suggestion budget is global, not per suggestion, and missing-implicits1 has many errors where a search is needed. #9189 splits missing-implicits1 into several tests. I think that's a better solution, since it avoids overly long search times for other tests with unrelated errors. But we should merge this quickly, so that the flakeyness of testing goes away. @nicolasstucki I have made you a reviewer of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/neg/missing-implicit1.scalacan easily have a different (but correct)output when the CI is overloaded.