Add quoted.Expr.asExprOf and Reflection.Tree.{asExprOf, isExpr} #9514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods allow checked casts from `Expr` or a `Tree`. `Tree.asExprOf` is similar to `Trem.seal` with the difference that it also checks if the tree is a valid term. Add `isExpr` and improve implemetation of `seal`, `sealOpt` and `ExprMap`.
nicolasstucki
force-pushed
the
add-asExprOf
branch
from
d545392 to
9b9ca24
Compare
nicolasstucki
force-pushed
the
add-asExprOf
branch
from
0eb74e6 to
e3ddbab
Compare
liufengyun
approved these changes
Aug 8, 2020
| case _: MethodType | _: PolyType => false | ||
| case _ => true | ||
| case _ => false | ||
|
|
There was a problem hiding this comment.
The isExpr will cause confusion for meta-programmers: what's the relation between expression and Expr[T]? What is the relationship between expression and Term?
There was a problem hiding this comment.
The is isExpr indicates that this term is a valid Expr[Any], therefore asExprOf will succeed. The names are intentionally similar as the are about the same concept. Docs can improve.
There was a problem hiding this comment.
Maybe make the method private?
There was a problem hiding this comment.
But users are intended to use it
Co-authored-by: Fengyun Liu <liu@fengy.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods allow checked casts from
Expror aTree.Tree.asExprOfis similar toTrem.sealwith the difference that it also checks if the tree is a valid term.Add
isExprand improve implemetation ofseal,sealOptandExprMap.