Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize core and frontend #9867

Merged
merged 7 commits into from
Oct 9, 2020
Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Sep 24, 2020

No description provided.

@odersky
Copy link
Contributor Author

odersky commented Sep 24, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

do buf += sym
for bc <- clazz.baseClasses; sym <- bc.info.decls.toList do
if sym.is(DeferredTerm) && !isImplemented(sym) && !ignoreDeferred(sym)
buf += sym
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then is required after #9859 -- the benchmarks fail due to this.

@dottybot
Copy link
Member

performance test failed:

Please check http://lamppc37.epfl.ch:8000/pull-9867-09-24-18.05.out for more information

@odersky
Copy link
Contributor Author

odersky commented Sep 24, 2020

test performance please

@dottybot
Copy link
Member

performance test scheduled: 7 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9867/ to see the changes.

Benchmarks is based on merging with master (7ee3a20)

@odersky
Copy link
Contributor Author

odersky commented Oct 2, 2020

test performance please

@dottybot
Copy link
Member

dottybot commented Oct 2, 2020

performance test scheduled: 5 job(s) in queue, 1 running.

@dottybot
Copy link
Member

dottybot commented Oct 2, 2020

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9867/ to see the changes.

Benchmarks is based on merging with master (371d8f5)

@odersky odersky mentioned this pull request Oct 6, 2020
@odersky
Copy link
Contributor Author

odersky commented Oct 6, 2020

test performance please

@dottybot
Copy link
Member

dottybot commented Oct 6, 2020

performance test scheduled: 2 job(s) in queue, 1 running.

@dottybot
Copy link
Member

dottybot commented Oct 6, 2020

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/9867/ to see the changes.

Benchmarks is based on merging with master (63dd4f9)

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit c98e187 into scala:master Oct 9, 2020
@liufengyun liufengyun deleted the optimize-frontend branch October 9, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants