Add top level rule for identifiers inside the backticks #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
approved these changes
Jun 25, 2019
| object `Backtics test` { | ||
| val x = MediaRange.`*/*` | ||
|
|
||
| val y = `MediaRange`.`*/*` |
There was a problem hiding this comment.
Looking forward to enjoy this fix on GitHub.com 😄
|
Thank you) I'll try to publish a new release... |
|
Looks like the release went through 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30
The only thing is that this fix changes how capital letter identifiers are highlighted inside of the back-quotes:
So previously
`MediaRange`would be marked as "entity.name.class", but now it's just a plain id. I don't think it is terribly important though, as most people wouldn't use back-quotes as a class name but maybe to define some constants.