Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Login via GitHub #12

Closed
heathermiller opened this issue May 17, 2016 · 3 comments
Closed

UI: Login via GitHub #12

heathermiller opened this issue May 17, 2016 · 3 comments
Labels
UI
Milestone
Sprint 1

Comments

@heathermiller
Copy link
Contributor

heathermiller commented May 17, 2016 •
edited by MasseGuillaume
Loading

UI side of things – Heather will further clarify what we mean in this ticket
@heathermiller heathermiller changed the title Login via GitHub Login via GitHub (globally throughout Scaladex) May 17, 2016
@heathermiller heathermiller changed the title Login via GitHub (globally throughout Scaladex) Login via GitHub (globally throughout Scaladex), UI May 17, 2016
@heathermiller heathermiller changed the title Login via GitHub (globally throughout Scaladex), UI Login via GitHub May 17, 2016
@heathermiller
Copy link
Contributor Author

Guillaume will comment with where this connects to the backend

@MasseGuillaume
Copy link
Contributor

MasseGuillaume commented May 17, 2016 •
edited
Loading

open a popup to /login
after oauth2 dance the popup will redirect to /callback
this page close the popup and notify the parent window (window.opener) that the login state has changed
https://github.com/scalacenter/scaladex2/blob/master/webapp/jvm/src/main/scala/ch.epfl.scala.index/Server.scala#L220-L234

@heathermiller heathermiller changed the title Login via GitHub UI: Login via GitHub May 17, 2016
@MasseGuillaume MasseGuillaume mentioned this issue Jun 12, 2016
Closed
11 tasks
@MasseGuillaume MasseGuillaume added this to the scaladays berlin milestone Jun 12, 2016
@MasseGuillaume MasseGuillaume mentioned this issue Jun 16, 2016
Closed
@MasseGuillaume
Copy link
Contributor

fixed in #193

adpi2 pushed a commit that referenced this issue Aug 19, 2024
@skingle
5 : artifact model to include new fields (#12)
002411a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
Sprint 1
Development

No branches or pull requests
2 participants
@heathermiller @MasseGuillaume